[ntuple] cache number of entries in reader #19877
Open
+13
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcanal
reviewed
Sep 12, 2025
Test Results 21 files 21 suites 3d 18h 32m 26s ⏱️ For more details on these failures, see this check. Results for commit 1623541. ♻️ This comment has been updated with latest results. |
silverweed
reviewed
Sep 15, 2025
jblomer
force-pushed
the
ntuple-cache-nentries
branch
from
4d5df2e to
1623541
Compare
pcanal
approved these changes
Sep 15, 2025
silverweed
reviewed
Sep 15, 2025
| @@ -82,6 +82,8 @@ private: | |||
| /// Retrieving descriptor data from an RNTupleReader is supposed to be for testing and information purposes, | |||
| /// not on a hot code path. | |||
| std::optional<ROOT::RNTupleDescriptor> fCachedDescriptor; | |||
| /// We know that the RNTupleReader is always reading a single RNTuple, so the number of entries is fixed. | |||
| ROOT::NTupleSize_t fCachedNEntries = kInvalidNTupleIndex; | |||
There was a problem hiding this comment.
Does this default make sense? Wouldn't 0 be a more apt choice?
There was a problem hiding this comment.
Also, maybe it's fine to just call it fNEntries at this point?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #19763